Darwin support #23
Open
Darwin support #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 28, 2021 15:34
Signed-off-by: Shay Bergmann <[email protected]>
Signed-off-by: Shay Bergmann <[email protected]>
Signed-off-by: Shay Bergmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nixpkgsas it is required for builds to work on current versions of macOS.naerskso that it works with currentnixpkgsI tested getting NixOS options from Darwin and getting nix-darwin options from NixOS and it seems to be working ok.
PS
As a semi-related aside, I also rebased the @elkowar fork on upstream to make it work with this (due to required newer versions as mentioned above). It took some conflict resolution but nothing too bad and it seems to work ok (see here).
Any reason not to upstream that?
It looks like an obvious improvement over not having those features...