Pr issue75 - readNetCDF_thermo() #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ermo. Updated to netcdf3. Needs to be standardized to follow other read_<format> functions probably.
removed unnecessary #include <netcdf> that caused build errors in container
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 32.70% 32.49% -0.22%
==========================================
Files 51 51
Lines 16838 16947 +109
==========================================
Hits 5507 5507
- Misses 11331 11440 +109 ☔ View full report in Codecov by Sentry. |
sjsprecious
reviewed
Jul 25, 2024
|
Also please use the keywords to close the corresponding GitHub issue. fix #75 |
johnmauff
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
@cenamiller This looks good to me. Thanks for adding the transplanted code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding 'thermo' branch function to main code to read netcdf files for thermo input - readNetCDF_thermo(). Updated to netcdf3. TO DO ONCE CORRECT THERMO OUTPUT IS BEING GENERATED: Needs to be standardized to follow other read_ functions, and maybe eliminate need for two functions for reading NetCDF (wind and thermo) by using mode switch.
fix #75