Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read THERMO variables from TDRP file #85

Merged
merged 7 commits into from
Jul 31, 2024
Merged

Conversation

sjsprecious
Copy link
Collaborator

@sjsprecious sjsprecious commented Jul 25, 2024

This PR:

  • adds additional variables for a THERMO run in the beltramiTR.tdrp input file
  • enables the SAMURAI code to read in those variables

The values in the TDRP file are set to -1 to make sure that the variables are read in correctly by the program.

Needs to check with Michael about the correct options later.

fix #72

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 98.14815% with 3 lines in your changes missing coverage. Please review.

Project coverage is 33.15%. Comparing base (159bb35) to head (7343bf5).

Files Patch % Lines
src/VarDriver3D.cpp 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   32.49%   33.15%   +0.65%     
==========================================
  Files          51       51              
  Lines       16947    17118     +171     
==========================================
+ Hits         5507     5675     +168     
- Misses      11440    11443       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@johnmauff johnmauff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjsprecious Thanks for the code modifications. They look good to me.

@sjsprecious sjsprecious merged commit 9402615 into main Jul 31, 2024
4 checks passed
@sjsprecious sjsprecious deleted the change_trdp_variables branch July 31, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CostFunctionThermo::Initialize variables to be added to TDRP
2 participants