Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spi definition for Zephyr 3.2+ compatibility #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cairnm
Copy link

@cairnm cairnm commented Mar 24, 2024

This branch updates the SPI definition to use &pinctrl which is a necessary change for ZMK using Zephyr 3.2 or greater. The update essentially replicates the example code in the ZMK docs.

I've tested this change and confirmed that it builds/runs when using the current ZMK main branch, and the underglow LEDs work as expected on my Hillside46.

@Matthew-PargaManasse
Copy link

I grabbed cairnm's changes and applied them to my build. I can confirm that it is functioning on my Hillside46.

Copy link

@CaptainFlint42 CaptainFlint42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also applied these changes and it worked for my Hillside 52.

@FilippeMafra
Copy link

I made the same changes and worked on my Hillside 48.

@LukeJohnson
Copy link

LukeJohnson commented Nov 27, 2024

I have also confirmed that these changes resolve the build issue on my fork.

After merging the branch to my fork the build is successful.

Thanks for the fix @cairnm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants