Bump minimum needed R version to 3.6 (easystats#478)

easystats/easystats#304
mmelendezb · Sep 15, 2022 · 6a4dc10 · 6a4dc10
1 parent cd0404b
commit 6a4dc10
Show file tree

Hide file tree

Showing 9 changed files with 42 additions and 46 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: performance
 Title: Assessment of Regression Models Performance
-Version: 0.9.2.2
+Version: 0.9.2.3
 Authors@R: 
     c(person(given = "Daniel",
              family = "Lüdecke",
@@ -62,7 +62,7 @@ License: GPL-3
 URL: https://easystats.github.io/performance/
 BugReports: https://github.com/easystats/performance/issues
 Depends:
-    R (>= 3.5)
+    R (>= 3.6)
 Imports:
     bayestestR (>= 0.12.0),
     insight (>= 0.18.2),

diff --git a/NAMESPACE b/NAMESPACE
@@ -1,5 +1,19 @@
 # Generated by roxygen2: do not edit by hand
 
+
+S3method(bayesplot::pp_check, lm)
+S3method(bayesplot::pp_check, glm)
+S3method(bayesplot::pp_check, glmmTMB)
+S3method(bayesplot::pp_check, glm.nb)
+S3method(bayesplot::pp_check, merMod)
+S3method(bayesplot::pp_check, MixMod)
+S3method(bayesplot::pp_check, mle2)
+S3method(bayesplot::pp_check, negbin)
+S3method(bayesplot::pp_check, polr)
+S3method(bayesplot::pp_check, rma)
+S3method(bayesplot::pp_check, vlm)
+S3method(bayesplot::pp_check, wbm)
+S3method(bayesplot::pp_check, BFBayesFactor)
 S3method(AIC,bife)
 S3method(as.data.frame,check_outliers)
 S3method(as.data.frame,icc)
@@ -527,21 +541,6 @@ export(test_performance)
 export(test_vuong)
 export(test_wald)
 export(variance_decomposition)
-if (getRversion() >= "3.6.0") {
-  S3method(bayesplot::pp_check, lm)
-  S3method(bayesplot::pp_check, glm)
-  S3method(bayesplot::pp_check, glmmTMB)
-  S3method(bayesplot::pp_check, glm.nb)
-  S3method(bayesplot::pp_check, merMod)
-  S3method(bayesplot::pp_check, MixMod)
-  S3method(bayesplot::pp_check, mle2)
-  S3method(bayesplot::pp_check, negbin)
-  S3method(bayesplot::pp_check, polr)
-  S3method(bayesplot::pp_check, rma)
-  S3method(bayesplot::pp_check, vlm)
-  S3method(bayesplot::pp_check, wbm)
-  S3method(bayesplot::pp_check, BFBayesFactor)
-}
 importFrom(insight,display)
 importFrom(insight,print_html)
 importFrom(insight,print_md)
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,9 @@
 # performance 0.9.x
 
+## Breaking Change
+
+* The minimum needed R version has been bumped to `3.6`.
+
 # performance 0.9.2
 
 ## General

diff --git a/R/backports.R b/R/backports.R
diff --git a/R/binned_residuals.R b/R/binned_residuals.R
@@ -50,7 +50,7 @@
 #' as.data.frame(result)
 #'
 #' # plot
-#' if (require("see") && getRversion() >= "3.6.0") {
+#' if (require("see")) {
 #'   plot(result)
 #' }
 #' @export

diff --git a/R/pp_check.R b/R/pp_check.R
@@ -44,8 +44,10 @@
 #' - Gabry, J., Simpson, D., Vehtari, A., Betancourt, M., and Gelman, A. (2019).
 #'   Visualization in Bayesian workflow. Journal of the Royal Statistical Society:
 #'   Series A (Statistics in Society), 182(2), 389–402. https://doi.org/10.1111/rssa.12378
+#'
 #' - Gelman, A., and Hill, J. (2007). Data analysis using regression and
 #'   multilevel/hierarchical models. Cambridge; New York: Cambridge University Press.
+#'
 #' - Gelman, A., Carlin, J. B., Stern, H. S., Dunson, D. B., Vehtari, A., and
 #'   Rubin, D. B. (2014). Bayesian data analysis. (Third edition). CRC Press.
 #' - Gelman, A., Hill, J., and Vehtari, A. (2020). Regression and Other Stories.
@@ -54,7 +56,7 @@
 #' @examples
 #' library(performance)
 #' model <- lm(mpg ~ disp, data = mtcars)
-#' if (require("see") && getRversion() >= "3.5.0") {
+#' if (require("see")) {
 #'   check_predictions(model)
 #' }
 #' @export
@@ -213,7 +215,7 @@ pp_check.glm <- function(object,
   }
 
   # get response data, and response term
-  response <- eval(.str2lang(insight::find_response(object)),
+  response <- eval(str2lang(insight::find_response(object)),
     envir = insight::get_response(object)
   )
   resp_string <- insight::find_terms(object)$response
@@ -244,21 +246,20 @@ pp_check.glmmTMB   <-
 
 
 
-#' @rawNamespace if (getRversion() >= "3.6.0") {
-#'   S3method(bayesplot::pp_check, lm)
-#'   S3method(bayesplot::pp_check, glm)
-#'   S3method(bayesplot::pp_check, glmmTMB)
-#'   S3method(bayesplot::pp_check, glm.nb)
-#'   S3method(bayesplot::pp_check, merMod)
-#'   S3method(bayesplot::pp_check, MixMod)
-#'   S3method(bayesplot::pp_check, mle2)
-#'   S3method(bayesplot::pp_check, negbin)
-#'   S3method(bayesplot::pp_check, polr)
-#'   S3method(bayesplot::pp_check, rma)
-#'   S3method(bayesplot::pp_check, vlm)
-#'   S3method(bayesplot::pp_check, wbm)
-#'   S3method(bayesplot::pp_check, BFBayesFactor)
-#' }
+#' @rawNamespace
+#' S3method(bayesplot::pp_check, lm)
+#' S3method(bayesplot::pp_check, glm)
+#' S3method(bayesplot::pp_check, glmmTMB)
+#' S3method(bayesplot::pp_check, glm.nb)
+#' S3method(bayesplot::pp_check, merMod)
+#' S3method(bayesplot::pp_check, MixMod)
+#' S3method(bayesplot::pp_check, mle2)
+#' S3method(bayesplot::pp_check, negbin)
+#' S3method(bayesplot::pp_check, polr)
+#' S3method(bayesplot::pp_check, rma)
+#' S3method(bayesplot::pp_check, vlm)
+#' S3method(bayesplot::pp_check, wbm)
+#' S3method(bayesplot::pp_check, BFBayesFactor)
 
 
 

diff --git a/man/binned_residuals.Rd b/man/binned_residuals.Rd
diff --git a/man/check_predictions.Rd b/man/check_predictions.Rd
diff --git a/tests/testthat/test-check_singularity.R b/tests/testthat/test-check_singularity.R
@@ -18,9 +18,7 @@ if (.runThisTest) {
     )
 
     test_that("check_singularity", {
-      if (paste0(R.Version()[c("major", "minor")], collapse = ".") > "3.5.3") {
-        expect_true(check_singularity(model))
-      }
+      expect_true(check_singularity(model))
     })
   }
 }