Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing BabyMEG constants #9

Closed
wants to merge 1 commit into from
Closed

Add missing BabyMEG constants #9

wants to merge 1 commit into from

Conversation

LorenzE
Copy link
Member

@LorenzE LorenzE commented Sep 17, 2018 •
edited
Loading

Add different BabyMEG magnetometer types.

larsoner
larsoner approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, +1 for merge.

This is in the MEGIN set so let's see what @jnenonen and @mkajola say.

@larsoner
Copy link
Member

Actually @LorenzE it looks like this conflicts with #8, can you make a PR into my branch instead to simplify things?

@larsoner
Copy link
Member

I realized it was easy just to cherry-pick, closing for #8

@larsoner larsoner closed this Sep 18, 2018
@LorenzE LorenzE deleted the missing branch October 9, 2018 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsoner larsoner larsoner approved these changes

@agramfort agramfort agramfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LorenzE @larsoner @agramfort