BUG: Fix bugs with split files #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hoechenberger the failure for ds003775 is unexpected: Looks like it's due to mne-tools/mne-python#11099, can you look? |
|
Ouch … I'm afraid I won't have time before the weekend, sorry |
|
This is ready for review/merge from my end 003775 will be red until mne-tools/mne-python#11143 is merged, but hopefully 000248 (where splits matter) and all others come back green. Once 3775 is fixed I'll restart CIs. So whoever reviews, if you're happy, feel free to mark for merge-when green. |
agramfort
approved these changes
Sep 7, 2022
| epochs_cleaned.save( | ||
| fname_epo_out, overwrite=True, split_naming='bids', | ||
| split_size=cfg._epochs_split_size) | ||
| # _update_for_splits(out_files, 'epochs_cleaned') |
There was a problem hiding this comment.
These were intentionally left in to remind us to do it when working on caching :)
| epochs_cleaned.save( | ||
| fname_out, overwrite=True, split_naming='bids', | ||
| split_size=cfg._epochs_split_size) | ||
| # _update_for_splits(out_files, 'epochs_cleaned') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging …
docs/source/changes.md)Closes #593
True TDD, should fail, then I'll fix it and mark ready for review.