Make write_raw_bids() raise if an unsuitable extension is provided in the BIDSPath #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the BIDSPath Some extensions / formats are only allowed for certain data types, e.g. .vhdr is (i)EEG-only. When passing a BIDSPath containing both datatype and extension to write_raw_bids(), in case of a mismatch we would previously simply silently replace the incorrect extension, effectively writing to a location (and file format) the user didn't expect. We now raise an exception in such situations. Fixes mne-tools#1041
Codecov Report
@@ Coverage Diff @@
## main #1053 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 25 25
Lines 3815 3816 +1
=======================================
+ Hits 3632 3633 +1
Misses 183 183
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some extensions / formats are only allowed for certain data types, e.g.
.vhdris (i)EEG-only.When passing a
BIDSPathcontaining bothdatatypeandextensiontowrite_raw_bids(), in case of a mismatch we would previously simply silently replace the incorrectextension, effectively writing to a location (and file format) the user didn't expect.We now raise an exception in such situations.
Fixes #1041
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: