-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event metadata handling #1285
Conversation
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽♂️ |
Hi @thht, I just had a quick glance and it already looks very clean and reasonable! Please also follow the steps described here (in particular a changelog item with a high level description of your addition): And tag me for a review once you are ready 🙏 |
1d5136d
to
424f575
Compare
@sappelhoff Thanks for the quick reply! As you can see, I added the authors, citation and changelog information. I also fixed the docs issue. Failing tests should be due to the bids-validator issue you already reported in #1287. So, I think, this one is ready for review! |
9fefedd
to
a85c7ab
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1285 +/- ##
==========================================
- Coverage 97.61% 97.45% -0.16%
==========================================
Files 40 40
Lines 8685 8779 +94
==========================================
+ Hits 8478 8556 +78
- Misses 207 223 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am very happy with this, thanks a lot!
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
PR Description
So far, mne-bids only uses
event_id
to handle events. However, we really like and use the event metadata functionality of MNE Python. So, here is an update that you can also use event metadata as an alternative.Merge checklist
Maintainer, please confirm the following before merging.
If applicable: