-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chpi to known channel list #1325
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1325 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 40 40
Lines 8872 8876 +4
=======================================
+ Hits 8648 8652 +4
Misses 224 224 ☔ View full report in Codecov by Sentry. |
ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Could you please add an entry to the changelog? Then we can merge it. |
Done! edit: Apparently I was already part of the author's list - weird, I never contributed here. Maybe that's from my involvement of MNE? |
you DID contribute in 2021! 😄 how the time flies: |
Thanks! |
haha, wow. I never actually used |
PR Description
cHPI was not in the mapping dictionary, I've added it and also added a test.
resolves #1323
Additionally, I found that there are some other channels that are not known/converted and some channel types that are not known to MNE but are still in the mapping dictionary (can they in practice ever arise if they're not in MNE?)
I think we should be able to get an up to date channel list from this code and could use it in the test. However, the module is private, making it harder to access.
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: