Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase-slope index using spectral_connectivity_time instead of spectral_connectivity_epochs #210
base: main
Are you sure you want to change the base?
Phase-slope index using spectral_connectivity_time instead of spectral_connectivity_epochs #210
Changes from 19 commits
2631a83
388ab8c
c38374a
b44da50
75a72b5
6cef3cb
dffda01
ef0a484
be0c3cd
ce68935
401a6a8
573211d
a96db00
ac393fe
b5ab63b
3c93427
5dad254
8820b6f
fd5738e
48e81a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if we should expose more of these options to the user, e.g. why just
padding
and not the smoothing stuff?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including some of the things commented here would be nice to better reflect the checks happening for the regular PSI function.
So as well as checking that seed -> target connectivity is > 0, should also check that target -> seed connectivity is < 0 and they are identical but just sign-flipped.