Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: functional connectivity #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ncullen93
Copy link

Hi all,

This is a duplicate of my mne-python PR, where I propose an expansion of the scope of mne-python's functional connectivity (FC) measures. I have just started my PhD and am working on EEG-based Connectomics, so it is ideal for me to incorporate my connectivity code to the mne-python package over the next few years.

Correlation-based and mutual information-based measures are quite common in the literature and easy to implement, so I've submitted some examples of those first. A good reference for FC measures is Wang et al (2014) "A systematic framework for functional connectivity measures."

For now, I will plan to continually implement various FC measures as I've found in the literature while awaiting discussion on where to take this. I will also continue learning the mne-python API so I can integrate my code better.

Again, ideally it would make sense to have measures from the 7 major categories of FC measures. The current functionality from "spectral.py" belongs to the 4th category in my understanding:

    1) correlation
    2) h^2
    3) mutual information
    4) coherence
    5) Granger
    6) transfer entropy
    7) MVAR-frequency domain-based techniques

To note, I would also like to incorporate dynamic functional connectivity (FC over multiple epochs) and more causal effective connectivity, so an entire discussion on connectivity overall might be worthwhile.

Best
Nick

@agramfort
Copy link
Member

thanks

please try to make travis happy and let us know when he is so we can review.

@choldgraf
Copy link
Collaborator

my 2 cents:

  1. I think adding some new functional connectivity metrics would be useful. That said..
  2. I'm also not a fan of just including 4 billion FC metrics, and making it easy for people to play around with whatever metric gives them significant results. I think it's worth a discussion about whether each proposed added metric gives something qualitatively different from previous ones.

@wmvanvliet wmvanvliet changed the base branch from master to main September 2, 2022 11:10
@wmvanvliet
Copy link
Collaborator

Just a note that connectivity has since been moved from mne-python to the mne-connectivity package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants