MAINT: Use bundle_tools_3 and fix various bugs

.github/workflows/build.yml

@@ -300,6 +300,7 @@ jobs:
           echo "MNE_INSTALLER_VERSION=${MNE_INSTALLER_VERSION}"
           echo "MNE_ACTIVATE=${MNE_ACTIVATE}" >> $GITHUB_ENV
           echo "MNE_ACTIVATE=${MNE_ACTIVATE}"
+          echo "MNE_INSTALL_PREFIX=$MNE_INSTALL_PREFIX" >> $GITHUB_ENV
           echo "NSIS_SCRIPTS_RAISE_ERRORS=1" >> $GITHUB_ENV
 
       - name: Download appropriate installer
@@ -405,6 +406,10 @@ jobs:
             for f in mne-python*.desktop; do echo "📂 $f:"; cat "$f"; echo; done
             popd
           fi
+          echo "Checking for pinned file..."
+          test -e "$MNE_INSTALL_PREFIX/conda-meta/pinned"
+          grep "openblas" "$MNE_INSTALL_PREFIX/conda-meta/pinned"
+
           echo "Checking permissions..."
           OWNER=`ls -ld "$(which python)" | awk '{print $3}'`
           echo "Got OWNER=$OWNER, should be $(whoami)"

assets/post_install_linux.sh

@@ -13,7 +13,7 @@ ${PREFIX}/bin/conda env config vars set MAMBA_NO_BANNER=1
 echo "ℹ️ Setting libmama as the conda solver."
 ${PREFIX}/bin/conda config --set solver libmamba
 
-echo "ℹ️ Pinning BLAS implementation to OpenBLAS"
+echo "ℹ️ Pinning BLAS implementation to OpenBLAS."
 echo "libblas=*=*openblas" >>${PREFIX}/conda-meta/pinned
 
 echo "ℹ️ Running mne sys_info."

assets/post_install_macOS.sh

@@ -31,15 +31,15 @@ fi
 MNE_APP_DIR="$APP_DIR/MNE-Python $MNE_VERSION"
 logger -p 'install.info' "📓 MNE_APP_DIR=$MNE_APP_DIR"
 
-logger -p 'install.info' "ℹ️ Moving root MNE .app bundles from $APP_DIR to $MNE_APP_DIR"
+logger -p 'install.info' "ℹ️ Moving root MNE .app bundles from $APP_DIR to $MNE_APP_DIR."
 $PERMS mkdir -p "$MNE_APP_DIR"
 $PERMS mv "$APP_DIR"/*\(MNE\).app "$MNE_APP_DIR"/
 
-logger -p 'install.info' "ℹ️ Fixing permissions of MNE .app bundles in $MNE_APP_DIR: new owner will be ${USER_FROM_HOMEDIR}"
+logger -p 'install.info' "ℹ️ Fixing permissions of MNE .app bundles in $MNE_APP_DIR: new owner will be ${USER_FROM_HOMEDIR}."
 $PERMS chown -R "$USER_FROM_HOMEDIR" "$MNE_APP_DIR"
 
 MNE_ICON_PATH="$PREFIX/Menu/mne.png"
-logger -p 'install.info' "ℹ️ Setting custom folder icon for $MNE_APP_DIR to $MNE_ICON_PATH"
+logger -p 'install.info' "ℹ️ Setting custom folder icon for $MNE_APP_DIR to $MNE_ICON_PATH."
 osascript \
     -e 'set destPath to "'"${MNE_APP_DIR}"'"' \
     -e 'set iconPath to "'"${MNE_ICON_PATH}"'"' \
@@ -59,26 +59,26 @@ if [ "${PYTHON_PLATFORM}" == "x86_64" ]; then
     ${PREFIX}/bin/conda env config vars set CONDA_SUBDIR=osx-64
 fi
 
-logger -p 'install.info' "ℹ️ Configuring Python to ignore user-installed local packages"
+logger -p 'install.info' "ℹ️ Configuring Python to ignore user-installed local packages."
 ${DSTBIN}/conda env config vars set PYTHONNOUSERSITE=1
 
-logger -p 'install.info' "ℹ️ Disabling mamba package manager banner"
+logger -p 'install.info' "ℹ️ Disabling mamba package manager banner."
 ${DSTBIN}/conda env config vars set MAMBA_NO_BANNER=1
 
-logger -p 'install.info' "ℹ️ Setting libmama as the conda solver."
+logger -p 'install.info' "ℹ️ Setting libmama as the conda solve.r"
 ${DSTBIN}/conda config --set solver libmamba
 
-logger -p 'install.info' "ℹ️ Configuring Matplotlib to use the Qt backend by default"
+logger -p 'install.info' "ℹ️ Configuring Matplotlib to use the Qt backend by default."
 sed -i '.bak' "s/##backend: Agg/backend: qtagg/" ${PREFIX}/lib/python${PYSHORT}/site-packages/matplotlib/mpl-data/matplotlibrc
 
-logger -p 'install.info' "ℹ️ Pinning BLAS implementation to OpenBLAS"
+logger -p 'install.info' "ℹ️ Pinning BLAS implementation to OpenBLAS."
 echo "libblas=*=*openblas" >> ${PREFIX}/conda-meta/pinned
 
-logger -p 'install.info' "ℹ️ Fixing permissions of entire conda environment for user=${USER_FROM_HOMEDIR}"
+logger -p 'install.info' "ℹ️ Fixing permissions of entire conda environment for user=${USER_FROM_HOMEDIR}."
 chown -R "$USER_FROM_HOMEDIR" "${PREFIX}"
 
-logger -p 'install.info' "ℹ️ Running mne sys_info"
+logger -p 'install.info' "ℹ️ Running mne sys_info."
 ${DSTBIN}/conda run mne sys_info || true
 
-logger -p 'install.info' "ℹ️ Opening in Finder ${MNE_APP_DIR}"
-open -R "${MNE_APP_DIR}"
+logger -p 'install.info' "ℹ️ Opening in Finder ${MNE_APP_DIR}/."
+open -R "${MNE_APP_DIR}/"

assets/post_install_windows.bat

@@ -1,17 +1,21 @@
-echo ℹSetting permissions on the Python installation to %USERNAME%.
-takeown /u %USERNAME% /f %PREFIX% /r /d y
+@ECHO OFF
 
-echo ℹConfiguring Python to ignore user-installed local packages.
-"%PREFIX%\bin\conda" env config vars set PYTHONNOUSERSITE=1
+echo Setting read/write permissions on the Python installation to %USERNAME%.
+icacls %PREFIX% /grant %USERNAME%:(OI)(CI)M /c /t /q
 
-echo ℹDisabling mamba package manager banner.
-"%PREFIX%\bin\conda" env config vars set MAMBA_NO_BANNER=1
+echo Configuring Python to ignore user-installed local packages.
+"%PREFIX%\Scripts\conda" env config vars set PYTHONNOUSERSITE=1
 
-echo ℹSetting libmama as the conda solver.
-"%PREFIX%\bin\conda" config --set solver libmamba
+echo Disabling mamba package manager banner.
+"%PREFIX%\Scripts\conda" env config vars set MAMBA_NO_BANNER=1
 
-echo ℹPinning BLAS implementation to OpenBLAS
-echo "libblas=*=*openblas" >> "%PREFIX%\bin\conda\conda-meta\pinned"
+echo Setting libmama as the conda solver.
+"%PREFIX%\Scripts\conda" config --set solver libmamba
 
-echo ℹRunning mne sys_info.
-"%PREFIX%\bin\conda" run mne sys_info
+echo Pinning BLAS implementation to OpenBLAS.
+echo "libblas=*=*openblas" >> "%PREFIX%\conda-meta\pinned"
+
+echo Running mne sys_info.
+"%PREFIX%\Scripts\conda" run mne sys_info
+
+timeout /t 5

recipes/mne-python_1.5/construct.yaml

@@ -114,7 +114,7 @@ specs:
   - pingouin =0.5.3
   - pycircstat =0.0.2
   # MRI
-  - fsleyes =1.8.2
+  - fsleyes =1.8.3
   - dcm2niix =1.0.20230411
   # Time-frequency analysis
   - pactools =0.3.1

tests/test_imports.py

@@ -33,6 +33,7 @@ def check_min_version(package, min_version):
 if platform.system() != "Windows":
     import mne_icalabel
 import autoreject
+import pyriemann
 import pyprep
 import pycrostates
 import darkdetect

tests/test_outdated.py

@@ -25,9 +25,7 @@ class Package:  # noqa: D101
     version_conda_forge: str | None = None
 
 
-allowed_outdated: set[str] = {
-    "fsleyes",  # some unknown bug where 1.8.3 can't be downloaded on 2023/09/01
-}
+allowed_outdated: set[str] = set()
 packages: list[Package] = []
 
 for spec in specs:

tools/extract_version.sh

@@ -42,16 +42,20 @@ elif [[ "$MACHINE" == "macOS" && "$PYMACHINE" == "arm64" ]]; then
 fi
 
 if [[ "$MACHINE" == "macOS" ]]; then
+    MNE_INSTALL_PREFIX="/Library/mne-python_${MNE_INSTALLER_VERSION}"
     MNE_INSTALLER_NAME="MNE-Python-${MNE_INSTALLER_VERSION}-${MACHINE}_${MACOS_SUFFIX}.pkg"
-    MNE_ACTIVATE="/Library/mne-python_${MNE_INSTALLER_VERSION}/bin/activate"
+    MNE_ACTIVATE="$MNE_INSTALL_PREFIX/bin/activate"
 elif [[ "$MACHINE" == "Linux" ]]; then
+    MNE_INSTALL_PREFIX="$HOME/mne-python/${MNE_INSTALLER_VERSION}"
     MNE_INSTALLER_NAME="MNE-Python-${MNE_INSTALLER_VERSION}-${MACHINE}.sh"
-    MNE_ACTIVATE="$HOME/mne-python/${MNE_INSTALLER_VERSION}/bin/activate"
+    MNE_ACTIVATE="$MNE_INSTALL_PREFIX/bin/activate"
 else
+    MNE_INSTALL_PREFIX="$HOME/mne-python/$MNE_INSTALLER_VERSION"
     MNE_INSTALLER_NAME="MNE-Python-${MNE_INSTALLER_VERSION}-${MACHINE}.exe"
-    MNE_ACTIVATE="$HOME/mne-python/$MNE_INSTALLER_VERSION/Scripts/activate"
+    MNE_ACTIVATE="$MNE_INSTALL_PREFIX/Scripts/activate"
 fi
 
+export MNE_INSTALL_PREFIX="$MNE_INSTALL_PREFIX"
 export MNE_INSTALLER_NAME="${MNE_INSTALLER_NAME}"
 export MNE_ACTIVATE="$MNE_ACTIVATE"
 export MNE_INSTALLER_ARTIFACT_ID="MNE-Python-${MACHINE}-${ARTIFACT_ID_SUFFIX}"