Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website homepage tweaks (funder logo, avatar size) #12595

Merged
merged 3 commits into from
May 2, 2024

Conversation

drammock
Copy link
Member

@drammock drammock commented May 1, 2024

inspired by #12258 and #12572, I looked at reducing the contributor avatar size on our homepage. this PR is that along with a couple minor tweaks I noticed along the way:

  1. Shrinks the homepage avatars. This probably won't show up in the CI doc build --- I think we render the avatars only on deploy builds, so to see the effect you'd need to build docs locally with the env variable set.
  2. replaces one of the few remaining PNG funder logos (Paris-Saclay Center for Data Science) with two SVGs (light and dark mode)
  3. fixes the intersphinx link for pyvista; it was causing a doc build warning about redirecting
  4. adjusts the pin on PydataSphinxTheme to be >= instead of == (this was causing me failed env solving because I locally build with the dev version of the theme).

Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@larsoner larsoner enabled auto-merge (squash) May 2, 2024 14:16
@drammock drammock disabled auto-merge May 2, 2024 14:41
@drammock drammock enabled auto-merge (squash) May 2, 2024 14:44
@drammock drammock changed the title use SVG logo; shrink avatars; update intersphinx URL; adjust pin Website homepage tweaks (funder logo, avatar size) May 2, 2024
@drammock drammock merged commit e28cba9 into mne-tools:main May 2, 2024
30 checks passed
@drammock drammock deleted the svg-logo branch May 2, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants