-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix HTML display of Spectrum objects #13041
Conversation
OK doc build finally works as expected: https://output.circle-artifacts.com/output/job/d15fc82a-e80e-4e7d-97b1-9f5deb544fce/artifacts/0/html/auto_tutorials/time-freq/10_spectrum_class.html In worse news, there are very weird things going on with pre-commit. We're running it in 3 places:
In this PR the hook was failing on azure because it wanted to change the README min dependency list from Python 3.9 to 3.10. that is a correct change because our README and pyproject.toml are out of sync with each other. When I proactively changed the readme from 3.9 to 3.10 in 13b06a3, the local run of the Note that the I'm scratching my head as to why we run precommit in 3 places, and not sure what to do to address this, other than remove the GHA run because (1) it's behaving weirdly and (2) it uses a dispreferred, maintenance-only precursor to precommit-ci. |
I think the argument was to save some CI resources given that people will have to fix things
Fixed and future-proofed by https://github.com/mne-tools/mne-python/pull/13040/files#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9R81 . So we can revert the removal (or not) here, up to you. |
Ok with me. Feel free to do it if you're at an actual computer (not phone). Otherwise I'll get to it next week maybe |
closes #13025