Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix HTML display of Spectrum objects #13041

Merged
merged 9 commits into from
Dec 22, 2024
Merged

fix HTML display of Spectrum objects #13041

merged 9 commits into from
Dec 22, 2024

Conversation

drammock
Copy link
Member

closes #13025

@drammock drammock requested a review from larsoner as a code owner December 20, 2024 20:59
@drammock
Copy link
Member Author

OK doc build finally works as expected: https://output.circle-artifacts.com/output/job/d15fc82a-e80e-4e7d-97b1-9f5deb544fce/artifacts/0/html/auto_tutorials/time-freq/10_spectrum_class.html
previously it was not erroring out but some of the _repr_html_() calls were failing, so the tables were only getting displayed for EpochsSpectrum, not for Spectrum objects.

In worse news, there are very weird things going on with pre-commit. We're running it in 3 places:

In this PR the hook was failing on azure because it wanted to change the README min dependency list from Python 3.9 to 3.10. that is a correct change because our README and pyproject.toml are out of sync with each other.

When I proactively changed the readme from 3.9 to 3.10 in 13b06a3, the local run of the dependency-sync hook was skipped, and now it succeeds on azure, but fails on GH Action (it wants to change it back from 3.10 to 3.9). I cannot figure out why.

Note that the dependency-sync action is not run on pre-commit.ci because it's excluded by the ci: skip: section of the config (which is ignored by azure/GHA).

I'm scratching my head as to why we run precommit in 3 places, and not sure what to do to address this, other than remove the GHA run because (1) it's behaving weirdly and (2) it uses a dispreferred, maintenance-only precursor to precommit-ci.

@larsoner
Copy link
Member

I'm scratching my head as to why we run precommit in 3 places

I think the argument was to save some CI resources given that people will have to fix things

and not sure what to do to address this, other than remove the GHA run because (1) it's behaving weirdly and (2) it uses a dispreferred, maintenance-only precursor to precommit-ci.

Fixed and future-proofed by https://github.com/mne-tools/mne-python/pull/13040/files#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9R81 . So we can revert the removal (or not) here, up to you.

@drammock
Copy link
Member Author

we can revert the removal

Ok with me. Feel free to do it if you're at an actual computer (not phone). Otherwise I'll get to it next week maybe

@larsoner larsoner enabled auto-merge (squash) December 22, 2024 01:08
@larsoner larsoner merged commit 90d9c91 into mne-tools:main Dec 22, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some HTML tables look wonky
3 participants