MRG: Refactor plot_alignment #9714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If possible could you also fix #9715 / #9585 (comment) ? |
|
I updated the branch with |
agramfort
reviewed
Sep 6, 2021
There was a problem hiding this comment.
so far so good !
@GuillaumeFavelier tell me when it's good enough from your end.
agramfort
reviewed
Sep 6, 2021
GuillaumeFavelier
changed the title
|
It's now ready on my end @agramfort, what do you think? |
|
Also @alexrockhill feel free to look if you have time |
agramfort
approved these changes
Sep 6, 2021
|
Didn't run it but looks like great fixes, thanks and sorry I didn't have the time to do the bug I made |
marsipu
pushed a commit
to marsipu/mne-python
that referenced
this pull request
Sep 6, 2021
* start with _plot_head_surface * refactor * add _plot_axes * update * fix * touch example * fix * update * return actor * add _plot_forward * add _plot_mri_fiducials * return actors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
plot_alignment()following #9689 (comment). It fixes #9542. It fixes #9715.It's still work in progress.
ToDO
The functions should all receive an instance of
_Rendereras first parameter and return a list ofvtkActors as first output.