ENH: Swallow PySide6 warning (#292)

mne-tools · Oct 21, 2024 · cf65b85 · cf65b85
1 parent 1b1d861
commit cf65b85
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.github/workflows/qt_viz_tests.yml b/.github/workflows/qt_viz_tests.yml
@@ -73,8 +73,8 @@ jobs:
           fi
           python -m pip install -ve .${PIP_OPTION} "PyQt6!=6.6.1" "PyQt6-Qt6!=6.6.1,!=6.6.2,!=6.6.3"
           if [[ "${{ matrix.pip }}" == "pre" ]]; then
-            echo "Upgrading to pre-release NumPy, SciPy, and matplotlib"
-            python -m pip install --upgrade --pre --only-binary ":all:" --default-timeout=60 --extra-index-url "https://pypi.anaconda.org/scientific-python-nightly-wheels/simple" "numpy>=2.0.0.dev0" "scipy>=1.14.0.dev0" "matplotlib>=3.9.0.dev0" "scikit-learn>=1.5.dev0"
+            echo "Upgrading to pre-release NumPy, SciPy, matplotlib, and pyqtgraph"
+            python -m pip install --upgrade --pre --only-binary ":all:" --default-timeout=60 --extra-index-url "https://pypi.anaconda.org/scientific-python-nightly-wheels/simple" "numpy>=2.0.0.dev0" "scipy>=1.14.0.dev0" "matplotlib>=3.9.0.dev0" "scikit-learn>=1.5.dev0" "git+https://github.com/pyqtgraph/pyqtgraph.git"
           fi
       - run: ./tools/get_testing_version.sh
         working-directory: ../mne-python
@@ -153,7 +153,7 @@ jobs:
           # Avoid a problematic version of PySide6
           # https://wiki.qt.io/Qt_for_Python_Development_Notes#1._Juni_2023
           if [[ "$QT_LIB" == "PySide6" ]]; then
-            QT_LIB_INSTALL="PySide6!=6.5.1,!=6.7.0,!=6.7.1"
+            QT_LIB_INSTALL="PySide6!=6.5.1,!=6.7.0,!=6.7.1,!=6.8.0,!=6.8.0.1"
           else
             QT_LIB_INSTALL="$QT_LIB"
           fi

diff --git a/mne_qt_browser/_pg_figure.py b/mne_qt_browser/_pg_figure.py
@@ -12,6 +12,7 @@
 import os
 import platform
 import sys
+import warnings
 import weakref
 from ast import literal_eval
 from collections import OrderedDict
@@ -3569,7 +3570,11 @@ def call(*args_, **kwargs_):
 
 def _disconnect(sig, *, allow_error=False):
     try:
-        sig.disconnect()
+        with warnings.catch_warnings():
+            warnings.filterwarnings(
+                "ignore", "Failed to disconnect", category=RuntimeWarning
+            )
+            sig.disconnect()
     except (TypeError, RuntimeError):  # if there are no connections, ignore it
         if not allow_error:
             raise