Fixup transaction validation for 1.2.0 #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per James, I actually got the release plan wrong for the RTH stuff. The idea was supposed to be, update all readers first, in 1.2.0, and only in the next release may writing memos be allowed. This means that, transaction validation should enforce for now that memos do not exist in the chain. In MCIP mobilecoinfoundation#26 we may introduce a mechanism to allow turning on the memos. That is not yet implemented. We will continue to work on that but by merging this to master now, we make it possible to branch for release now, and create clients capable of reading memos, while we could later make a release that accepts writing memos in the future. We can discuss separately if the scope for 1.2.0 should be to include a `block_version`-aware `TransactionBuilder`, it's possible that it should be and then we aren't ready to branch. But then this commit is still a fine basis for future iteration.
remoun
approved these changes
Feb 8, 2022
eranrund
approved these changes
Feb 8, 2022
remoun
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per James, I actually got the release plan wrong for the RTH stuff.
The idea was supposed to be, update all readers first, in 1.2.0,
and only in the next release may writing memos be allowed.
This means that, transaction validation should enforce for now
that memos do not exist in the chain.
In MCIP 26 we may introduce a mechanism to allow turning on the
memos. That is not yet implemented. We will continue to work on that
but by merging this to master now, we make it possible to branch
for release conceivably, and create clients capable of reading memos, while
we could later make a release that accepts writing memos in the
future.
We can discuss separately if the scope for 1.2.0 should be to
include a
block_version-awareTransactionBuilder, it's possiblethat it should be and then we aren't ready to branch. (We also still
need to adjust some of the memo schemas.) But then this
commit is still a fine basis for future iteration.