port a select subset of the changes from mixed transactions for candidate 1.2 #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date 1.2 The changes ported here are: * Rename `token_id` to `fee_token_id` in `TxPrefix`. This avoids a breaking change between this and 1.3 in the hashes. * Make `TransactionBuilder::new` take a fee amount instead of a fee token id This also changes te memo builder trait, so that it will be compatible with the burn redemption memo builder which we hope to port next. This also makes `TransactionBuilder` possibly return an error. * Adapt all clients and sdks for `TransactionBuilder::new` changes. * Adapt all tests for this change * Bring the `Amount::new` function which makes the test code nicer.
cbeck88
requested review from
jcape,
the-real-adammork,
eranrund,
dolanbernard,
a team and
remoun
remoun
approved these changes
May 3, 2022
eranrund
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes ported here, from (#1827) are:
token_idtofee_token_idinTxPrefix. This avoids a breakingchange between this and 1.3 in the hashes.
TransactionBuilder::newtake a fee amount instead of a fee token idThis also changes te memo builder trait, so that it will be compatible with
the burn redemption memo builder which we hope to port next.
This also makes
TransactionBuilder::newpossibly return an error.TransactionBuilder::newchanges.Amount::newfunction which makes the test code nicer.This does NOT port:
add_outputtake an amount instead of avalue: u64. That is needed for mixed transactions but isn't needed here, and requires more changes to the clients and sdks, so we avoid it in this branch.