Fix(mobx): Safer method to consume Iterator.prototype #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d7d76f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tonyraoul
force-pushed
the
fix-map-set-browser-compatability
branch
from
c9879d9
to
176fcb8
Compare
tonyraoul
force-pushed
the
fix-map-set-browser-compatability
branch
from
176fcb8
to
2398f5a
Compare
tonyraoul
changed the title
tonyraoul
changed the title
3 tasks
tonyraoul
changed the title
tonyraoul
changed the title
|
No worries, these things happen in ever changing browser land! Thanks for the quick fix. Up to the next breakage🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code change checklist
/docs. For new functionality, at leastAPI.mdshould be updatedyarn mobx test:performance)Really sorry, I might have introduced a bug here
thanks @zeldigas for reporting!
Context
For some projects setups,
Observablemap.prototype.forEach,ObservableSet.prototype.forEachmight throw an error on older browsers and Safari, I am genuinely sorry about this one.I wrongfully assumed that
Iterator.prototypeis widely available but that's not the case.