Contracts and harnesses for `dangling`, `from_raw_parts`, `slice_from_raw_parts`, `to_raw_parts` in NonNull #127

QinyuanWu · 2024-10-22T02:48:13Z

Towards #53

Contracts and harnesses for dangling, from_raw_parts, slice_from_raw_parts, to_raw_parts in NonNull

Discussion

NonNull::slice_from_raw_parts: requested new Kani API to compare byte by byte
NonNull::to_raw_parts: unstable vtable comparison 'Eq'

Verification Result

SUMMARY:
 ** 0 of 141 failed

VERIFICATION:- SUCCESSFUL
Verification Time: 0.17378491s

Complete - 6 successfully verified harnesses, 0 failures, 6 total.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

…/danielhumanmod/verify-rust-std into olivia/pointer_creation_and_init

library/core/src/ptr/non_null.rs

QinyuanWu · 2024-11-13T00:07:03Z

@zhassan-aws I just starting to get compiler errors when I run kani on this branch:

Kani Rust Verifier 0.56.0 (standalone)
error: cannot find a built-in macro with name `SmartPointer`
    --> /Users/owo/Desktop/verify-rust-std/library/core/src/marker.rs:1068:1
     |
1068 | / pub macro SmartPointer($item:item) {
1069 | |     /* compiler built-in */
1070 | | }
     | |_^

error: attributes starting with `rustc` are reserved for use by the `rustc` compiler
    --> /Users/owo/Desktop/verify-rust-std/library/core/src/marker.rs:1095:12
     |
1095 |     impl<#[rustc_runtime] const RUNTIME: bool> Compat<RUNT...
     |            ^^^^^^^^^^^^^

......

I just pulled the latest kani changes and re-built it but the error persists. Latest kani git log:

commit abd68b963c6e4a9508ce9f6950f3d26134631eba
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Nov 11 17:13:34 2024 -0600

    Bump tests/perf/s2n-quic from `65d55a4` to `cb41b35` (#3706)
    
    Bumps [tests/perf/s2n-quic](https://github.com/aws/s2n-quic) from
    `65d55a4` to `cb41b35`.
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a
    href="https://github.com/aws/s2n-quic/commit/cb41b35a9bc0412435b70b5038df0681a881e414"><code>cb41b35</code></a>
    feat(s2n-quic-dc): mtu probing event subscriber (<a
    href="https://redirect.github.com/aws/s2n-quic/issues/2374">#2374</a>)</li>
    <li><a
    href="https://github.com/aws/s2n-quic/commit/56ce95a48db7dd2ed31110d9d408775793bbcb3a"><code>56ce95a</code></a>
    test(s2n-quic-core): add metric snapshot registry (<a

@danielhumanmode also reproduced this error on his local environment and found that Kani compiled the code successfully on commit 13e6695(before the latest merge from main).

carolynzech · 2024-11-13T14:44:53Z

@zhassan-aws I just starting to get compiler errors when I run kani on this branch:
I just pulled the latest kani changes and re-built it but the error persists. Latest kani git log:

commit abd68b963c6e4a9508ce9f6950f3d26134631eba
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Nov 11 17:13:34 2024 -0600

    Bump tests/perf/s2n-quic from `65d55a4` to `cb41b35` (#3706)
    
    Bumps [tests/perf/s2n-quic](https://github.com/aws/s2n-quic) from
    `65d55a4` to `cb41b35`.
    <details>
    <summary>Commits</summary>
    <ul>
    <li><a
    href="https://github.com/aws/s2n-quic/commit/cb41b35a9bc0412435b70b5038df0681a881e414"><code>cb41b35</code></a>
    feat(s2n-quic-dc): mtu probing event subscriber (<a
    href="https://redirect.github.com/aws/s2n-quic/issues/2374">#2374</a>)</li>
    <li><a
    href="https://github.com/aws/s2n-quic/commit/56ce95a48db7dd2ed31110d9d408775793bbcb3a"><code>56ce95a</code></a>
    test(s2n-quic-core): add metric snapshot registry (<a

@danielhumanmode also reproduced this error on his local environment and found that Kani compiled the code successfully on commit 13e6695(before the latest merge from main).

@QinyuanWu Is there a reason why you're running on Kani's main branch instead of the features/verify-rust-std branch? If not, please try running Kani from the features/verify-rust-std branch instead.

QinyuanWu · 2024-11-13T22:45:13Z

eatures/verify-rust-std br

@carolynzech This resolved the compiler errors in PR #105 but not this one ;-;
@zhassan-aws I tried running ./scripts/run-kani.sh but the cbmc-viewer error still persists:

For the script, I pulled the latest changes from main and it seems like cbmc-viewer is still being installed/upgraded:

==> Upgrading aws/tap/cbmc-viewer
  3.9 -> 3.10 
Error: Your Command Line Tools are too outdated.
Update them from Software Update in System Settings.

zhassan-aws · 2024-11-14T00:29:04Z

Did you merge the latest commits (including at least 6aa2661)?

zhassan-aws · 2024-11-14T00:34:53Z

If you have the up-to-date changes, these should be the contents of tool_config/kani-version.toml:

$ cat tool_config/kani-version.toml 
# This version should be updated whenever there is a change that makes this version of kani
# incompatible with the verify-std repo.

[kani]
commit = "26c078e097025499baf6e360210a21989d3605e0"

…/danielhumanmod/verify-rust-std into olivia/pointer_creation_and_init

QinyuanWu · 2024-11-14T06:50:16Z

@zhassan-aws Thank you the compiler issue is resolved after running the script and executing kani from /verify-rust-std/kani_build/scripts/kani. I then tried the kani I built before(/kani/scripts/kani) and it surprisingly worked again. Not sure what happened lol(maybe because some commits from main were not merged in?). Previous comments are addressed.

library/core/src/ptr/non_null.rs

qinheping

LGTM.

zhassan-aws

Almost there. Can you also resolve the conflict?

library/core/src/ptr/non_null.rs

QinyuanWu · 2024-11-21T02:05:26Z

@zhassan-aws Resolved comments and conflicts:

SUMMARY:
 ** 0 of 141 failed

VERIFICATION:- SUCCESSFUL
Verification Time: 0.17723987s

Complete - 24 successfully verified harnesses, 0 failures, 24 total.

zhassan-aws

Please re-resolve the conflicts, and I'll merge it.

QinyuanWu · 2024-11-25T19:05:22Z

@zhassan-aws Resolved conflicts. Thank you so much!

SUMMARY:
 ** 0 of 141 failed

VERIFICATION:- SUCCESSFUL
Verification Time: 0.17861353s

Complete - 28 successfully verified harnesses, 0 failures, 28 total.

QinyuanWu and others added 9 commits October 21, 2024 22:45

draft for pointer creation & init APIs

d3fb92d

Merge branch 'model-checking:main' into olivia/pointer_creation_and_init

3ae10be

kani pointer compare bug fixed, using same_allocation, trait eq failure

90f7b4b

Merge branch 'model-checking:main' into olivia/pointer_creation_and_init

babde0b

Merge branch 'olivia/pointer_creation_and_init' of https://github.com…

5a6268e

…/danielhumanmod/verify-rust-std into olivia/pointer_creation_and_init

Merge branch 'model-checking:main' into olivia/pointer_creation_and_init

ae49f93

add zero_len_slice in dangling, failed eq check in to_raw_parts

e5a7f14

Merge branch 'model-checking:main' into olivia/pointer_creation_and_init

a7cc36b

resolve partial eq

13e6695

QinyuanWu marked this pull request as ready for review November 7, 2024 19:54

QinyuanWu requested a review from a team as a code owner November 7, 2024 19:54

Merge branch 'model-checking:main' into olivia/pointer_creation_and_init

23c9f66

zhassan-aws reviewed Nov 11, 2024

View reviewed changes

library/core/src/ptr/non_null.rs Outdated Show resolved Hide resolved

library/core/src/ptr/non_null.rs Outdated Show resolved Hide resolved

library/core/src/ptr/non_null.rs Outdated Show resolved Hide resolved

library/core/src/ptr/non_null.rs Outdated Show resolved Hide resolved

address PR comments

e408f24

QinyuanWu mentioned this pull request Nov 13, 2024

Contracts & Harnesses for add, addr, and align_offset #105

Merged

carolynzech assigned qinheping and zhassan-aws Nov 13, 2024

QinyuanWu and others added 3 commits November 13, 2024 19:10

Merge branch 'model-checking:main' into olivia/pointer_creation_and_init

0e8f53f

Merge branch 'olivia/pointer_creation_and_init' of https://github.com…

8aad9e5

…/danielhumanmod/verify-rust-std into olivia/pointer_creation_and_init

address PR comments

27f3f6c

QinyuanWu requested a review from zhassan-aws November 14, 2024 06:50

qinheping reviewed Nov 15, 2024

View reviewed changes

QinyuanWu added 2 commits November 15, 2024 11:31

address PR comments

113e257

minor fix after merge

a9051fd

QinyuanWu requested a review from qinheping November 15, 2024 20:07

qinheping approved these changes Nov 18, 2024

View reviewed changes

zhassan-aws reviewed Nov 19, 2024

View reviewed changes

library/core/src/ptr/non_null.rs Outdated Show resolved Hide resolved

library/core/src/ptr/non_null.rs Outdated Show resolved Hide resolved

library/core/src/ptr/non_null.rs Outdated Show resolved Hide resolved

library/core/src/ptr/non_null.rs Outdated Show resolved Hide resolved

QinyuanWu added 2 commits November 20, 2024 17:54

address PR comments, add correctness clause for slice_from_raw_parts

b0ea303

merge from main

01b5d7f

QinyuanWu requested a review from zhassan-aws November 21, 2024 02:05

zhassan-aws approved these changes Nov 25, 2024

View reviewed changes

merge from main

93900d9

zhassan-aws enabled auto-merge (squash) November 25, 2024 19:51

Minor fixes

37d210e

zhassan-aws approved these changes Nov 25, 2024

View reviewed changes

zhassan-aws merged commit 07318df into model-checking:main Nov 25, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Contracts and harnesses for `dangling`, `from_raw_parts`, `slice_from_raw_parts`, `to_raw_parts` in NonNull #127

Contracts and harnesses for `dangling`, `from_raw_parts`, `slice_from_raw_parts`, `to_raw_parts` in NonNull #127

QinyuanWu commented Oct 22, 2024 •

edited

Loading

QinyuanWu commented Nov 13, 2024 •

edited

Loading

carolynzech commented Nov 13, 2024

QinyuanWu commented Nov 13, 2024 •

edited

Loading

zhassan-aws commented Nov 14, 2024

zhassan-aws commented Nov 14, 2024

QinyuanWu commented Nov 14, 2024 •

edited

Loading

qinheping left a comment

zhassan-aws left a comment

QinyuanWu commented Nov 21, 2024

zhassan-aws left a comment

QinyuanWu commented Nov 25, 2024

Contracts and harnesses for dangling, from_raw_parts, slice_from_raw_parts, to_raw_parts in NonNull #127

Contracts and harnesses for dangling, from_raw_parts, slice_from_raw_parts, to_raw_parts in NonNull #127

Conversation

QinyuanWu commented Oct 22, 2024 • edited Loading

Discussion

Verification Result

QinyuanWu commented Nov 13, 2024 • edited Loading

carolynzech commented Nov 13, 2024

QinyuanWu commented Nov 13, 2024 • edited Loading

zhassan-aws commented Nov 14, 2024

zhassan-aws commented Nov 14, 2024

QinyuanWu commented Nov 14, 2024 • edited Loading

qinheping left a comment

Choose a reason for hiding this comment

zhassan-aws left a comment

Choose a reason for hiding this comment

QinyuanWu commented Nov 21, 2024

zhassan-aws left a comment

Choose a reason for hiding this comment

QinyuanWu commented Nov 25, 2024

Contracts and harnesses for `dangling`, `from_raw_parts`, `slice_from_raw_parts`, `to_raw_parts` in NonNull #127

Contracts and harnesses for `dangling`, `from_raw_parts`, `slice_from_raw_parts`, `to_raw_parts` in NonNull #127

QinyuanWu commented Oct 22, 2024 •

edited

Loading

QinyuanWu commented Nov 13, 2024 •

edited

Loading

QinyuanWu commented Nov 13, 2024 •

edited

Loading

QinyuanWu commented Nov 14, 2024 •

edited

Loading