Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing for custom requests, notification, and result types #33

Merged
merged 7 commits into from
Nov 5, 2024

Conversation

jspahrsummers
Copy link
Member

Resolves #26.

IIRC @ashwin-ant, this was something you were running into? Does this fix do what you'd want?

Copy link
Member

@ashwin-ant ashwin-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this looks great!

@jspahrsummers jspahrsummers merged commit 2b9b1b7 into main Nov 5, 2024
4 checks passed
@jspahrsummers jspahrsummers deleted the justin/custom-requests branch November 5, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set request or notification handler for custom types
2 participants