Add a rawBody optional parameter #81
Open
+26
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
SSEServerTransport
requires nodejsIncomingMessage
as a first parameter,but this
IncomingMessage
need not to be consumed by other body parser middlewares,because in
body-parser
,_readableState
will be checked and if you already consumed request body,body-parser
will be thrown an error.If you use server framework like fastify, body parser is installed at an initialization timing.
So I'd like to add a third and forth parameter to handlePostMessage to use an already parsed raw body.
How Has This Been Tested?
Yes, link library to real application.
Breaking Changes
No.
Types of changes
Checklist
Additional context