Added BrowserSync npm Grunt package. #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error for the missing npm package.
ryanurban
approved these changes
Jul 10, 2017
There was a problem hiding this comment.
Nice catch/fix, Vinny! Think this recently got removed with some of the awesome coming work from our devops guys.
This is good, you correctly added the CR tag, and just a reminder that when you do PR's on SQ1 to add all the FE leads on it: Casey, Samuel, Dave3, myself. I went ahead and added Casey / left off Dave3 for this one as it's super simple and he doesn't need the noise right now.
So once it's approved by everyone, ping me and we'll go through the merge process together. Nice job!
|
Yup, looks great! Was just a mixup with last weeks work when patrick and i were merging a lot of shuffling on the package.json. 🐋 💨 |
faction23
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grunt task exists but throws an error for the missing npm package.
I added this to the dependencies (not devDependencies) since the other grunt packages are there.
Testing instructions (if needed):
Prerequisites: (local dev project is already setup).
yarn installgrunt dev