Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use safer makedirs function #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sunshinekitty
Copy link

@sunshinekitty sunshinekitty commented Dec 26, 2016

This is the equivalent of mkdir -p, mkdir will fail if you need to create more than one level of folders.

@tonioo
Copy link
Member

tonioo commented Jan 17, 2017

@sunshinekitty Sorry for my late answer. Can you tell me why do you need this modification?

@sunshinekitty
Copy link
Author

mkdir will fail if you need to create more than one level of folders

e.g. set home_dir in the [dovecot] section to /mnt/mail/dovecot, if /mnt/mail doesn't exist it will fail, using makedirs is safer

@tonioo
Copy link
Member

tonioo commented Jan 17, 2017

Indeed, but in this particular example, the /mnt/mail/dovecot is not created by the installer directly but by a call to useradd...

@sunshinekitty
Copy link
Author

i don't remember the issue exactly that i ran into 22 days ago at this point, but a child dir was not created properly and the installer crapped out

merge or close, i don't care

@kryskool
Copy link
Contributor

I prefer to close this PR, because if subdirectory creation failed, it indicate that there is a problem.

@sunshinekitty on which distro that problem appear ?

@ksaadDE
Copy link
Contributor

ksaadDE commented Jun 27, 2022

Does it work, does it not? Is it closed?^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants