Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Liked/Nope Font size to Options #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MatiBot
Copy link

@MatiBot MatiBot commented Sep 6, 2015

No description provided.

@mabeebam
Copy link
Contributor

@MatiBot Thanks, exactly what I need too! Really looking forward to see your PR getting merged!

@MatiBot
Copy link
Author

MatiBot commented Oct 22, 2015

You can use my fork in the meantime

@mabeebam
Copy link
Contributor

@MatiBot I reference MDCSwipeToChoose via CocoaPods...
@modocache Any idea on when to merge the extensions from @MatiBot ?

@MatiBot
Copy link
Author

MatiBot commented Oct 22, 2015

pod 'MDCSwipeToChoose', :git => 'https://github.com/MatiBot/MDCSwipeToChoose.git', :commit => 'fef67df7a57373b6db821f503ca07b8c136dee64'

@mabeebam
Copy link
Contributor

@MatiBot Of course, did not think about that. Thanks for pointing out!

@MatiBot
Copy link
Author

MatiBot commented Oct 22, 2015

No problem

@vikmeup
Copy link
Contributor

vikmeup commented Oct 22, 2015

@MatiBot instead of passing CGFloat as a font size, it has to be UIFont, which will allow to set font as well. Consistency and best practices.
Could you please change that?

@mabeebam
Copy link
Contributor

@vikmeup Please check PR #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants