Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve url detection to avoid false positives #138

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

makepanic
Copy link
Contributor

I've noticed that the url detection is a bit too simple as it creates false hyperlinks for regular words starting with http.

e.g. httpstatus would create a hyperlink even if it's unlikely expected to be there.

Note: I'm not sure if it's only for me but the test script isn't working. It also seems like there's no github action to actually execute the tests.

 FAIL  test/spec.ts
  ● Test suite failed to run

    TypeError: Cannot read properties of undefined (reading 'createNodeArray')

      at visitor (node_modules/ts-jest/dist/transformers/hoist-jest.js:84:61)

@mohsen1
Copy link
Owner

mohsen1 commented Jun 21, 2024

Thank you for your PR and pointing out to the infra issues. I fixed the tests in CI. Please rebase and I'm happy to merge

@makepanic makepanic force-pushed the improve-url-detection branch from f0d83ff to 120ff0c Compare June 21, 2024 20:11
@makepanic
Copy link
Contributor Author

Thanks. I've rebased onto master.

@makepanic makepanic force-pushed the improve-url-detection branch from 120ff0c to f554371 Compare June 22, 2024 20:00
@mohsen1 mohsen1 merged commit c561ffc into mohsen1:master Jun 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants