Tu 482 #14
Tu 482 #14
Conversation
There was a problem hiding this comment.
Love it. Lets meet today to discuss creation of messages. I have some documentation and code semi done for communication between backend and the gateway that will necessitate some special routes to cook up 👨🍳
For this PR. just take a look at the comments I added (mainly remove the create message and create measurement) and I'll approve after
| import { ModelAttributes, DataTypes } from 'sequelize'; | ||
|
|
||
| export const sensorsModel:ModelAttributes = { | ||
| id: { |
There was a problem hiding this comment.
id for a sensor is just a 6 bit number. When nodes send a message they will attach what data comes from which sensor id. Will need to not have guid here
| }; | ||
|
|
||
| interface CreateSensorBody { | ||
| sensor:Partial<Sensor>; |
There was a problem hiding this comment.
We are leaving this partial, but which fields are allowed to be omitted? Maybe we type this more explicitly, as well as check in the route if req fields are missing and reply with an error if so.
There was a problem hiding this comment.
also do we want to check for auth? verifying a usertype is what they said earlier?
| measurement:Partial<Measurement> | ||
| } | ||
|
|
||
| export const createMeasurement: RequestHandler = async (req, res) => { |
There was a problem hiding this comment.
We should meet to discuss message/measurement creation (its a special topic. Lets omit of any message creation routes for this PR
Sensors functionality