expanded exit points

mojaloop · Oct 19, 2019 · 0917fb4 · 0917fb4
1 parent 691c3bc
commit 0917fb4
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/src/lib/masterSpan/index.js b/src/lib/masterSpan/index.js
@@ -37,16 +37,25 @@ const cacheSpanContext = async (spanContext, state, content) => {
       return (service === 'ml_notification_event' && tags.transactionType === 'transfer' && tags.transactionAction === 'fulfil')
     }
 
-    const isPrepareError = () => {
+    const isNotificationError = () => {
       return (
         service === 'ml_notification_event' &&
         tags.transactionType === 'transfer' &&
         tags.transactionAction === 'prepare' &&
         (!!tags.errorCode || (!!trace && !!trace[trace.length - 1].spanContext.tags.errorCode)))
     }
 
-    const isLastSpan = () => {
-      return (isPrepareError() || isFulfil() || service === 'final service')
+    const isPrepareError = () => {
+      return (
+        service === 'ml_transfer_prepare' &&
+        tags.transactionType === 'transfer' &&
+        tags.transactionAction === 'prepare' &&
+        !!tags.errorCode
+        )
+    }
+
+    const isLastSpan = () => { // TODO EXPAND THOSE TO FULLY COVER ALL EXIT POINTS
+      return (isPrepareError() || isNotificationError() || isFulfil() || service === 'final service')
     }
 
     const newSpanId = crypto.randomBytes(8).toString('hex')