Certificate chain support, Apache Commons Compress support and Skipping of INDEX.LIST #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 10a2976)
…, which are: - Incorrect download artifact names when using packed or versioned jars - Extra attempted downloads over and above declarations in the JNLP file (via the URL classloading mechanism)
|
I don't see any test ... |
|
The pull request illustrates one way of incorporating Apache Commons Compress Pack200 support into the plugin given that native Pack200 support has been removed from the newer JDKs. It would be useful for this to be incorporated in some manner. I will look into the unit testing possibilities further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests provides some code changes that may be of use, which is to enable the certchain jarsigner argument, which is useful when signing with hardware tokens. Additionally, it includes a change to skip the INDEX.LIST file, which prior to the change implicitly results in failed jar downloads when using .pack.gz resources only. Furthermore it adds configurable support for the Apache Commons Compress Pack200 algorithm that may be used to reinstate the pack200 feature that has been removed in newer versions of the JDK.