Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Test::Mojo::header_* tests #1593

Merged
merged 1 commit into from
Nov 1, 2020

Conversation

rage311
Copy link
Contributor

@rage311 rage311 commented Oct 30, 2020

Summary

Added Test::Mojo::header_* tests. Though now I'm unsure of the merge-ability of the separate pull requests, even though it seemed like a good idea to separate the concerns a bit at first.

Motivation

More tests addressing #1488

References

#1488

@kraih kraih requested a review from a team October 30, 2020 10:23
@kiwiroy
Copy link
Contributor

kiwiroy commented Oct 30, 2020

Minor, but some lines need perltidy.

kraih
kraih previously requested changes Oct 30, 2020
Copy link
Member

@kraih kraih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits.

@mergify mergify bot dismissed kraih’s stale review October 30, 2020 18:38

Pull request has been modified.

Copy link
Member

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mergify mergify bot merged commit d721b4f into mojolicious:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants