Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Bootstrap 5 and removing dependency on JQuery. #2155

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

sergiotarxz
Copy link
Contributor

Summary

Migrating to Boostrap 5 and removing dependency on JQuery.

Motivation

Issue #1975

References

#1975

@sergiotarxz
Copy link
Contributor Author

sergiotarxz commented Feb 13, 2024

Screenshot from 2024-02-14 00-51-58
Screenshot from 2024-02-14 00-51-50
Screenshot from 2024-02-14 00-51-32
Screenshot from 2024-02-14 00-50-54
Screenshot from 2024-02-14 00-50-44
Screenshot from 2024-02-14 00-50-33
Right new Left Old.

@sergiotarxz sergiotarxz force-pushed the migrate-to-bootstrap-5 branch 2 times, most recently from da5ada3 to 85e773e Compare February 14, 2024 00:06
@sergiotarxz sergiotarxz force-pushed the migrate-to-bootstrap-5 branch 3 times, most recently from eae4190 to ac66b45 Compare February 14, 2024 10:16
@sergiotarxz
Copy link
Contributor Author

Also this pull requests fixes a bug where tap for more was not changing to tap for less on click.

@sergiotarxz sergiotarxz force-pushed the migrate-to-bootstrap-5 branch from ac66b45 to 068eb26 Compare February 14, 2024 10:26
Copy link
Contributor Author

@sergiotarxz sergiotarxz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments

@sergiotarxz sergiotarxz requested a review from kraih February 14, 2024 16:26
@sergiotarxz sergiotarxz force-pushed the migrate-to-bootstrap-5 branch from 068eb26 to cf07c76 Compare February 14, 2024 19:54
@sergiotarxz sergiotarxz force-pushed the migrate-to-bootstrap-5 branch from cf07c76 to 991e874 Compare February 14, 2024 20:00
@sergiotarxz sergiotarxz force-pushed the migrate-to-bootstrap-5 branch from 991e874 to a3e1c1d Compare February 14, 2024 20:09
kraih
kraih previously requested changes Feb 14, 2024
t/mojolicious/exception_lite_app.t Outdated Show resolved Hide resolved
t/mojolicious/rebased_lite_app.t Outdated Show resolved Hide resolved
@sergiotarxz sergiotarxz force-pushed the migrate-to-bootstrap-5 branch from a3e1c1d to 3b3a8b0 Compare February 14, 2024 20:38
@mergify mergify bot dismissed kraih’s stale review February 14, 2024 20:38

Pull request has been modified.

@sergiotarxz sergiotarxz force-pushed the migrate-to-bootstrap-5 branch from 3b3a8b0 to efcb790 Compare February 15, 2024 00:42
@sergiotarxz
Copy link
Contributor Author

There is a screenshot I have not posted
image

@sergiotarxz sergiotarxz requested a review from kraih February 15, 2024 21:48
@sergiotarxz sergiotarxz marked this pull request as draft February 15, 2024 22:21
@sergiotarxz
Copy link
Contributor Author

I added use strict to the javascript and discovered a bunch of errors.

@sergiotarxz
Copy link
Contributor Author

sergiotarxz commented Feb 15, 2024

I just discovered there was a code path I was not testing, I tested it and fixed the following:

  • Added popper.js. (Required by tooltip)
  • Ensured tooltips actually work.
  • Migrated all data- to data-bs
  • const drawerEl
  • 'use strict'; everywhere
  • In the codepath of 404 debug this should be tested if (handleEl === null) return;

I was not able to take a screenshot to tooltips working though because they depend on the mouse being over them.

@sergiotarxz sergiotarxz force-pushed the migrate-to-bootstrap-5 branch from efcb790 to fd8733e Compare February 15, 2024 22:55
@sergiotarxz
Copy link
Contributor Author

@kraih Would you be in favor of moving the embedded javascript in the template to a file? Maybe in another pr.

@sergiotarxz sergiotarxz force-pushed the migrate-to-bootstrap-5 branch from fd8733e to 6bfb41a Compare February 15, 2024 22:58
@sergiotarxz sergiotarxz marked this pull request as ready for review February 15, 2024 23:00
@sergiotarxz sergiotarxz force-pushed the migrate-to-bootstrap-5 branch from 6bfb41a to 0400142 Compare February 16, 2024 16:23
@kraih
Copy link
Member

kraih commented Feb 26, 2024

@kraih Would you be in favor of moving the embedded javascript in the template to a file? Maybe in another pr.

Can't say, would depend on how clean the resulting code ends up.

@kraih kraih requested review from a team and Grinnz March 5, 2024 18:34
@kraih kraih merged commit 04f320c into mojolicious:main Mar 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants