-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading to Bootstrap 5 and removing dependency on JQuery. #2155
Conversation
da5ada3
to
85e773e
Compare
eae4190
to
ac66b45
Compare
Also this pull requests fixes a bug where |
ac66b45
to
068eb26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments
068eb26
to
cf07c76
Compare
cf07c76
to
991e874
Compare
991e874
to
a3e1c1d
Compare
a3e1c1d
to
3b3a8b0
Compare
3b3a8b0
to
efcb790
Compare
I added use strict to the javascript and discovered a bunch of errors. |
I just discovered there was a code path I was not testing, I tested it and fixed the following:
I was not able to take a screenshot to tooltips working though because they depend on the mouse being over them. |
efcb790
to
fd8733e
Compare
@kraih Would you be in favor of moving the embedded javascript in the template to a file? Maybe in another pr. |
fd8733e
to
6bfb41a
Compare
6bfb41a
to
0400142
Compare
Can't say, would depend on how clean the resulting code ends up. |
Summary
Migrating to Boostrap 5 and removing dependency on JQuery.
Motivation
Issue #1975
References
#1975