Cookbook: POST instead of GET in streaming example #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example with GET makes no sense, as GET method has no body. Use POST instead.
kraih
requested review from
a team,
marcusramberg,
kraih,
christopherraa and
Grinnz
Grinnz
approved these changes
Mar 20, 2024
kraih
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The example with GET makes no sense, as GET method has no body. Use POST instead.
Motivation
When looking for the way how to do chunked requests I have searched the docs for POST, because I expected that should there be a relevant example, it would use POST. But the Cookbook uses GET for streaming body, which makes no sense.
References
Discussed on IRC #mojo.