Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for partitioned cookies #2196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rawleyfowler
Copy link
Contributor

@rawleyfowler rawleyfowler commented Aug 28, 2024

Summary

Firefox is soon going to ignore third-party aka "foreign" aka SameSite: None

Motivation

These changes allow Mojolicious to handle the new "Partitioned" attribute, as well as adding the ability to set Partitioned on Mojolicious::Sessions cookies.

References

https://www.ietf.org/archive/id/draft-cutler-httpbis-partitioned-cookies-00.html

https://github.com/privacycg/CHIPS

fixes #2179

@rawleyfowler rawleyfowler changed the title Add partitioned cookies Add handling of partitioned cookies Aug 28, 2024
@kraih kraih requested review from a team, marcusramberg, kraih, christopherraa and Grinnz August 28, 2024 16:54
kraih
kraih previously requested changes Aug 28, 2024
Copy link
Member

@kraih kraih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some values are not ordered alphabetically and documentation is missing.

@rawleyfowler rawleyfowler requested a review from kraih August 28, 2024 17:13
@mergify mergify bot dismissed kraih’s stale review August 28, 2024 17:13

Pull request has been modified.

lib/Mojolicious/Sessions.pm Outdated Show resolved Hide resolved
@rawleyfowler
Copy link
Contributor Author

We could also mark this as experimental, though it is implemented in most browsers.

Copy link
Contributor

mergify bot commented Nov 22, 2024

This pull request is now in conflicts. Could you fix it @rawleyfowler? 🙏

Copy link
Contributor

mergify bot commented Nov 25, 2024

This pull request is now in conflicts. Could you fix it @rawleyfowler? 🙏

@rawleyfowler rawleyfowler changed the title Add handling of partitioned cookies Add support for partitioned cookies Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Support session cookies with "Partitioned"
2 participants