fix: issue when module runned by deno or bun #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason when deno or bun runtime environments are used
`new StackUtils().capture(2)[1].getFileName()` construct returns
file path as is on the system, not as file url
as it's visible on example below the call will just fail
```bash
$ echo "import Path from 'npm:@mojojs/path'; Path.currentFile();" > path.test.ts
$ deno run --allow-read path.test.ts
error: Uncaught (in promise) TypeError: Invalid URL: '/home/agrechkin/test/path.test.ts'
at getSerialization (ext:deno_url/00_url.js:98:11)
at new URL (ext:deno_url/00_url.js:405:27)
at Object.fileURLToPath (node:url:1152:40)
at Function.fromFileURL (file:///home/agrechkin/.cache/deno/npm/registry.npmjs.org/@mojojs/path/1.6.0/lib/path.js:186:29)
at Function.currentFile (file:///home/agrechkin/.cache/deno/npm/registry.npmjs.org/@mojojs/path/1.6.0/lib/path.js:153:21)
at file:///home/agrechkin/test/path.test.ts:1:43
```
the provided change will make sure `Path.currentFile` and `Path.callerFile` are working properly.
|
Unfortunate that |
|
Thanks, merged. Lets see how it goes. I've also added tests for callerFile and currentFile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason when deno or bun runtime environments are used
new StackUtils().capture(2)[1].getFileName()construct returns file path as is on the system, not as file urlas it's visible on example below the call will just fail
the provided change will make sure
Path.currentFileandPath.callerFileare working properly.