Merge branch 'patch-2' into feature/add-windows-to-build

mok-liee · Mar 5, 2024 · 7538ffa · 7538ffa
2 parents 25fb817 + 8c3eb47
commit 7538ffa
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/apps/generator-cli/src/README.md b/apps/generator-cli/src/README.md
@@ -245,3 +245,4 @@ yarn add @openapitools/[email protected]
 
 Please leave a star.
 
+
diff --git a/apps/generator-cli/src/app/helpers/index.ts b/apps/generator-cli/src/app/helpers/index.ts
@@ -1,3 +1,5 @@
+import path from 'path';
+
 const isWin = () => process.platform === 'win32';
 
 /**
@@ -6,6 +8,6 @@ const isWin = () => process.platform === 'win32';
  */
 export const javaCmd: string = process.env['JAVA_HOME']
   ? isWin()
-    ? `"${process.env['JAVA_HOME']}/bin/java"`
-    : `${process.env['JAVA_HOME']}/bin/java`
+    ? `"${path.join(process.env['JAVA_HOME'], 'bin', 'java')}"`
+    : `${path.join(process.env['JAVA_HOME'], 'bin', 'java')}`
   : 'java';
diff --git a/apps/generator-cli/src/app/services/generator.service.ts b/apps/generator-cli/src/app/services/generator.service.ts
@@ -243,9 +243,17 @@ export class GeneratorService {
         )}" org.openapitools.codegen.OpenAPIGenerator`
       : `-jar "${cliPath}"`;
 
-    return [javaCmd, process.env['JAVA_OPTS'], subCmd, 'generate', appendix]
+    const command = [
+      javaCmd,
+      process.env['JAVA_OPTS'],
+      subCmd,
+      'generate',
+      appendix,
+    ]
       .filter(isString)
       .join(' ');
+
+    return this.isWin() ? `"${command}"` : command;
   };
 
   private isWin = () => process.platform === 'win32';
Original file line number	Diff line number	Diff line change
Expand Up		@@ -245,3 +245,4 @@ yarn add @openapitools/[email protected]

		Please leave a star.