Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi…

…x/47799-loading-behind-background

.eslintrc.pr.js

@@ -0,0 +1,7 @@
+module.exports = {
+    extends: './.eslintrc',
+    plugins: ['deprecation'],
+    rules: {
+        'deprecation/deprecation': 'error',
+    },
+};

.github/actions/javascript/getDeployPullRequestList/getDeployPullRequestList.ts

@@ -46,7 +46,7 @@ async function run() {
                 }
 
                 // If it's anywhere else in this page, the the prior release is the next item in the page
-                if (indexOfCurrentRelease > 0) {
+                if (indexOfCurrentRelease >= 0) {
                     priorTag = filteredData.at(indexOfCurrentRelease + 1)?.tag_name;
                     done();
                 }

.github/actions/javascript/getDeployPullRequestList/index.js

@@ -11535,7 +11535,7 @@ async function run() {
                 return filteredData;
             }
             // If it's anywhere else in this page, the the prior release is the next item in the page
-            if (indexOfCurrentRelease > 0) {
+            if (indexOfCurrentRelease >= 0) {
                 priorTag = filteredData.at(indexOfCurrentRelease + 1)?.tag_name;
                 done();
             }

.github/workflows/deploy.yml

@@ -196,13 +196,13 @@ jobs:
       - name: Upload desktop sourcemaps artifact
         uses: actions/upload-artifact@v4
         with:
-          name: ${{ env.SHOULD_DEPLOY_PRODUCTION && 'desktop-sourcemaps-artifact' || 'desktop-staging-sourcemaps-artifact' }}
+          name: ${{ fromJSON(env.SHOULD_DEPLOY_PRODUCTION) && 'desktop-sourcemaps-artifact' || 'desktop-staging-sourcemaps-artifact' }}
           path: ./desktop/dist/www/merged-source-map.js.map
 
       - name: Upload desktop build artifact
         uses: actions/upload-artifact@v4
         with:
-          name: ${{ env.SHOULD_DEPLOY_PRODUCTION && 'desktop-build-artifact' || 'desktop-staging-build-artifact' }}
+          name: ${{ fromJSON(env.SHOULD_DEPLOY_PRODUCTION) && 'desktop-build-artifact' || 'desktop-staging-build-artifact' }}
           path: ./desktop-build/NewExpensify.dmg
 
   iOS:
@@ -407,7 +407,7 @@ jobs:
       - name: Upload web sourcemaps artifact
         uses: actions/upload-artifact@v4
         with:
-          name: ${{ env.SHOULD_DEPLOY_PRODUCTION && 'web' || 'web-staging' }}-sourcemaps-artifact
+          name: ${{ fromJSON(env.SHOULD_DEPLOY_PRODUCTION) && 'web' || 'web-staging' }}-sourcemaps-artifact
           path: ./dist/merged-source-map.js.map
 
       - name: Compress web build .tar.gz and .zip
@@ -418,13 +418,13 @@ jobs:
       - name: Upload .tar.gz web build artifact
         uses: actions/upload-artifact@v4
         with:
-          name: ${{ env.SHOULD_DEPLOY_PRODUCTION && 'web' || 'web-staging' }}-build-tar-gz-artifact
+          name: ${{ fromJSON(env.SHOULD_DEPLOY_PRODUCTION) && 'web' || 'web-staging' }}-build-tar-gz-artifact
           path: ./webBuild.tar.gz
 
       - name: Upload .zip web build artifact
         uses: actions/upload-artifact@v4
         with:
-          name: ${{ env.SHOULD_DEPLOY_PRODUCTION && 'web' || 'web-staging' }}-build-zip-artifact
+          name: ${{ fromJSON(env.SHOULD_DEPLOY_PRODUCTION) && 'web' || 'web-staging' }}-build-zip-artifact
           path: ./webBuild.zip
 
   postSlackMessageOnFailure:
@@ -591,8 +591,8 @@ jobs:
   postSlackMessageOnSuccess:
     name: Post a Slack message when all platforms deploy successfully
     runs-on: ubuntu-latest
-    if: ${{ fromJSON(needs.checkDeploymentSuccess.outputs.IS_ALL_PLATFORMS_DEPLOYED) }}
-    needs: [prep, checkDeploymentSuccess, createPrerelease, finalizeRelease]
+    if: ${{ always() && fromJSON(needs.checkDeploymentSuccess.outputs.IS_ALL_PLATFORMS_DEPLOYED) }}
+    needs: [prep, android, desktop, iOS, web, checkDeploymentSuccess, createPrerelease, finalizeRelease]
     steps:
       - name: 'Announces the deploy in the #announce Slack room'
         uses: 8398a7/action-slack@v3

.github/workflows/lint.yml

@@ -28,6 +28,11 @@ jobs:
         env:
           CI: true
 
+      - name: Run ESLint with stricter checks on changed files
+        run: |
+          # shellcheck disable=SC2046
+          npx eslint --config ./.eslintrc.pr.js $(git diff --diff-filter=AM --name-only main -- "*.js" "*.ts" "*.tsx")
+
       - name: Verify there's no Prettier diff
         run: |
           npm run prettier -- --loglevel silent

android/app/build.gradle

@@ -110,8 +110,8 @@ android {
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
         multiDexEnabled rootProject.ext.multiDexEnabled
-        versionCode 1009003300
-        versionName "9.0.33-0"
+        versionCode 1009003500
+        versionName "9.0.35-0"
         // Supported language variants must be declared here to avoid from being removed during the compilation.
         // This also helps us to not include unnecessary language variants in the APK.
         resConfigs "en", "es"