Merge pull request Expensify#36950 from FitseTLT/fix-lhn-bold-issue-f…

…or-deleted-message Fix - LHN - When you delete a message from a room, the conversation in the members remains bolded
mollfpr · Feb 22, 2024 · 3e77445 · 3e77445
2 parents 6a63e02 + e584f66
commit 3e77445
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/libs/SidebarUtils.ts b/src/libs/SidebarUtils.ts
@@ -242,7 +242,9 @@ function getOptionData({
     result.policyID = report.policyID;
     result.stateNum = report.stateNum;
     result.statusNum = report.statusNum;
-    result.isUnread = ReportUtils.isUnread(report);
+    // When the only message of a report is deleted lastVisibileActionCreated is not reset leading to wrongly
+    // setting it Unread so we add additional condition here to avoid empty chat LHN from being bold.
+    result.isUnread = ReportUtils.isUnread(report) && !!report.lastActorAccountID;
     result.isUnreadWithMention = ReportUtils.isUnreadWithMention(report);
     result.hasDraftComment = report.hasDraft;
     result.isPinned = report.isPinned;

diff --git a/tests/ui/UnreadIndicatorsTest.js b/tests/ui/UnreadIndicatorsTest.js
@@ -229,6 +229,7 @@ function signInAndGetAppWithUnreadChat() {
                 lastVisibleActionCreated: reportAction9CreatedDate,
                 lastMessageText: 'Test',
                 participantAccountIDs: [USER_B_ACCOUNT_ID],
+                lastActorAccountID: USER_B_ACCOUNT_ID,
                 type: CONST.REPORT.TYPE.CHAT,
             });
             const createdReportActionID = NumberUtils.rand64();
@@ -388,6 +389,7 @@ describe('Unread Indicators', () => {
                                     lastReadTime: '',
                                     lastVisibleActionCreated: DateUtils.getDBTime(utcToZonedTime(NEW_REPORT_FIST_MESSAGE_CREATED_DATE, 'UTC').valueOf()),
                                     lastMessageText: 'Comment 1',
+                                    lastActorAccountID: USER_C_ACCOUNT_ID,
                                     participantAccountIDs: [USER_C_ACCOUNT_ID],
                                     type: CONST.REPORT.TYPE.CHAT,
                                 },