Merge pull request Expensify#28583 from paultsimura/fix/28170-mention…

…-on-delete fix: Chat - App displays mention suggestion for sometime when we remove spaces before
mollfpr · Oct 2, 2023 · b09b7e3 · b09b7e3
2 parents bbdb8f5 + dfa66cf
commit b09b7e3
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/pages/home/report/ReportActionCompose/SuggestionMention.js b/src/pages/home/report/ReportActionCompose/SuggestionMention.js
@@ -234,7 +234,10 @@ function SuggestionMention({
 
     useEffect(() => {
         calculateMentionSuggestion(selection.end);
-    }, [selection, calculateMentionSuggestion]);
+
+        // We want this hook to run only on selection change.
+        // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, [selection]);
 
     const updateShouldShowSuggestionMenuToFalse = useCallback(() => {
         setSuggestionValues((prevState) => {