stan fix

mollie · Sep 3, 2024 · 4633e38 · 4633e38
1 parent a177540
commit 4633e38
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/controllers/admin/AdminMollieLogsController.php b/controllers/admin/AdminMollieLogsController.php
@@ -262,6 +262,7 @@ public function displayAjaxGetLog()
 
         /** @var LoggerInterface $logger */
         $logger = $this->module->getService(LoggerInterface::class);
+        $log = null;
 
         try {
             /** @var \MolLog|null $log */

diff --git a/src/Repository/CollectionRepository.php b/src/Repository/CollectionRepository.php
@@ -51,6 +51,6 @@ public function findOneBy(array $keyValueCriteria, $langId = null): ?\ObjectMode
 
         $first = $psCollection->getFirst();
 
-        return false === $first ? null : $first;
+        return $first == false ? null : $first;
     }
 }
diff --git a/tests/phpstan/phpstan_base.neon b/tests/phpstan/phpstan_base.neon
@@ -42,7 +42,7 @@ parameters:
     - '#Parameter \#1 \$value of method ControllerCore\:\:ajaxRender\(\) expects null, string\|false given.#'
     - '#Call to function is_subclass_of\(\) with.*will always evaluate to false.#'
     - '#Call to function is_array\(\) with.*will always evaluate to false.#'
-    - '#Property AdminControllerCore\:\:\$_use_found_rows (string) does not accept false.#'
+    - '#Property AdminControllerCore\:\:\$_use_found_rows \(string\) does not accept false.#'
     - '#Access to undefined constant PrestaShopLogger::LOG_SEVERITY_LEVEL_INFORMATIVE.#'
     - '#Access to undefined constant PrestaShopLogger::LOG_SEVERITY_LEVEL_WARNING.#'
     - '#Access to undefined constant PrestaShopLogger::LOG_SEVERITY_LEVEL_ERROR.#'