Skip to content

Commit

Permalink
phpstan and csfixer
Browse files Browse the repository at this point in the history
  • Loading branch information
mandan2 committed Oct 9, 2023
1 parent faa9ac4 commit 5ead63f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
4 changes: 0 additions & 4 deletions controllers/admin/AdminMollieSettingsController.php
Original file line number Diff line number Diff line change
Expand Up @@ -227,17 +227,13 @@ private function setEnvironmentForCloudSync(): void
return;
}

/* @phpstan-ignore-next-line */
/** @var \Ps_eventbus $eventbusModule */
$eventbusModule = \Module::getInstanceByName('ps_eventbus');

Check failure on line 231 in controllers/admin/AdminMollieSettingsController.php

View workflow job for this annotation

GitHub Actions / PHPStan (1.7.6.8)

PHPDoc tag @var for variable $eventbusModule contains unknown class Ps_eventbus.

Check failure on line 231 in controllers/admin/AdminMollieSettingsController.php

View workflow job for this annotation

GitHub Actions / PHPStan (1.7.7.0)

PHPDoc tag @var for variable $eventbusModule contains unknown class Ps_eventbus.

/* @phpstan-ignore-next-line */
if (version_compare($eventbusModule->version, '1.9.0', '>=')) {

Check failure on line 233 in controllers/admin/AdminMollieSettingsController.php

View workflow job for this annotation

GitHub Actions / PHPStan (1.7.6.8)

Access to property $version on an unknown class Ps_eventbus.

Check failure on line 233 in controllers/admin/AdminMollieSettingsController.php

View workflow job for this annotation

GitHub Actions / PHPStan (1.7.7.0)

Access to property $version on an unknown class Ps_eventbus.
/* @phpstan-ignore-next-line */
/** @var PresenterService $eventbusPresenterService */
$eventbusPresenterService = $eventbusModule->getService(PresenterService::class);

Check failure on line 235 in controllers/admin/AdminMollieSettingsController.php

View workflow job for this annotation

GitHub Actions / PHPStan (1.7.6.8)

Call to method getService() on an unknown class Ps_eventbus.

Check failure on line 235 in controllers/admin/AdminMollieSettingsController.php

View workflow job for this annotation

GitHub Actions / PHPStan (1.7.7.0)

Call to method getService() on an unknown class Ps_eventbus.

/* @phpstan-ignore-next-line */
Media::addJsDef([
'contextPsEventbus' => $eventbusPresenterService->expose($this->module, ['orders']),
]);
Expand Down
2 changes: 1 addition & 1 deletion mollie.php
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ public function install()
$moduleManager = ModuleManagerBuilder::getInstance()->build();

try {
/**
/*
* NOTE: install method upgrades the module if there is a newer version
*/
if (
Expand Down
2 changes: 2 additions & 0 deletions tests/phpstan/phpstan_base.neon
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,7 @@ parameters:
- '#Parameter \#1 \$value of method ControllerCore\:\:ajaxRender\(\) expects null, string\|false given.#'
- '#Call to function is_subclass_of\(\) with.*will always evaluate to false.#'
- '#Call to function is_array\(\) with.*will always evaluate to false.#'
- '#ps_eventbus#'
- '#PsEventbus#'

level: 5

0 comments on commit 5ead63f

Please sign in to comment.