Merge pull request #481 from Invertus/fixed-review-issues

fixed review issues
mollie · Dec 2, 2021 · f54ebe5 · f54ebe5
2 parents f595c8e + 9f0c4c9
commit f54ebe5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/controllers/front/webhook.php b/controllers/front/webhook.php
@@ -74,7 +74,6 @@ protected function executeWebhook()
         if (!$this->module->api) {
             return 'API key is missing or incorrect';
         }
-
         try {
             if (TransactionUtility::isOrderTransaction($transactionId)) {
                 $payment = $transactionService->processTransaction($this->module->api->orders->get($transactionId, ['embed' => 'payments']));

diff --git a/src/Handler/Order/OrderCreationHandler.php b/src/Handler/Order/OrderCreationHandler.php
@@ -167,7 +167,7 @@ public function createOrder($apiPayment, $cartId, $isKlarnaOrder = false)
 
         $this->module->validateOrder(
             (int) $cartId,
-            (int) Configuration::get(Mollie\Config\Config::MOLLIE_STATUS_OPEN),
+            (int) Configuration::get(Mollie\Config\Config::MOLLIE_STATUS_AWAITING),
             (float) $apiPayment->amount->value,
             isset(Config::$methods[$apiPayment->method]) ? Config::$methods[$apiPayment->method] : $this->module->name,
             null,

diff --git a/src/Service/ApiService.php b/src/Service/ApiService.php
@@ -147,6 +147,8 @@ public function getMethodsForConfig(MollieApiClient $api, $path)
 
     private function getMethodsObjForConfig($apiMethods)
     {
+        $this->environment = (int) $this->configurationAdapter->get(Config::MOLLIE_ENVIRONMENT);
+
         $methods = [];
         $defaultPaymentMethod = new MolPaymentMethod();
         $defaultPaymentMethod->enabled = false;