PIPRES-329: Use Mollie mapped status for initial subscription order #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjas1997
reviewed
Oct 16, 2023
| @@ -258,23 +262,30 @@ private function createSubscription(Payment $transaction, MolRecurringOrder $rec | |||
| $newCart->secure_key | |||
| ); | |||
| } catch (\Throwable $exception) { | |||
| if (!NumberUtility::isEqual($cartTotal, $subscriptionPaidTotal)) { | |||
There was a problem hiding this comment.
Could check it prior and not inside the catch
tomjas1997
reviewed
Oct 16, 2023
| $specificPrice->delete(); | ||
|
|
||
| throw $exception; | ||
| } | ||
|
|
||
| if (!NumberUtility::isEqual($cartTotal, $subscriptionPaidTotal)) { |
There was a problem hiding this comment.
Yeah, seems like it should be just prior to validateOrder
tomjas1997
approved these changes
Oct 16, 2023
mandan2
deleted the
PIPRES-329-block-incorrect-pricing-subscription-orders
branch
JevgenijVisockij
pushed a commit
that referenced
this pull request
Jan 16, 2024
…827) * PIPRES-329: Use Mollie mapped status for initial subscription order * moved price compare before validateOrder call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this approach was used but temporary we changed initial status to awaiting to let incorrect pricing orders to be submitted. As awaiting status is not logable, transaction ID is not being inserted into payment, so had to change it back.