PISHPS-329 UrlParsingService - matching trackign code from tracking url #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acking url when not entered correctly
BlackScorp
requested changes
Aug 1, 2024
| * - Index 0 contains the parsed tracking code (if found), or an empty string if no code is found. | ||
| * - Index 1 contains the original URL. | ||
| */ | ||
| public function parseTrackingCodeFromUrl(string $value): array |
There was a problem hiding this comment.
i think that can be dangerous, since we dont know for each provier the tracking code. i would rather suggest extract url and put query parameters as code (if code contains URL)
BlackScorp
requested changes
Aug 6, 2024
| @@ -333,7 +333,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| include: | |||
| - shopware: '6.6.4.1' | |||
There was a problem hiding this comment.
revert shopware versions in the pipelines, you have the old ones
| @@ -168,7 +174,7 @@ endif | |||
| php switch-composer.php prod | |||
| # ------------------------------------------------------------------------------------------------- | |||
| @echo "CREATE ZIP FILE" | |||
| cd .. && zip -qq -r -0 ./.build/MolliePayments.zip MolliePayments/* -x '*/vendor/*' '*.editorconfig' '*.git*' '*.reports*' '*/.idea*' '*/tests*' '*/node_modules*' '*/makefile' '*.DS_Store' '*/.shopware-extension.yml' '*/switch-composer.php' '*/phpunit.xml' '*/.phpunuhi.xml' '*/.infection.json' '*/phpunit.autoload.php' '*/.phpstan*' '*/.php_cs.php' '*/phpinsights.php' | |||
There was a problem hiding this comment.
wron merge, add vendor again
|
|
||
| if (class_exists(PaymentException::class) && !class_exists(AsyncPaymentFinalizeException::class) && !class_exists(CustomerCanceledAsyncPaymentException::class)) { |
There was a problem hiding this comment.
wrong merge, add the statements again
| @@ -76,7 +76,8 @@ public function fetch(array $ids): array | |||
| SELECT LOWER(HEX(mollie_refund.id)) as id, | |||
| type, | |||
| public_description, | |||
| internal_description | |||
There was a problem hiding this comment.
remove the comma from SQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.