Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PISHPS-350 type check to CancelLineController #829

Merged
merged 1 commit into from
Sep 5, 2024
Merged

PISHPS-350 type check to CancelLineController #829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Controller/Api/Order/CancelLineController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public function statusAction(Request $request, Context $context): Response
/** @var OrderLine $line */
foreach ($lines as $line) {
$metadata = $line->metadata;
if (! property_exists($metadata, 'orderLineItemId')) {
if (!is_object($metadata) || ! property_exists($metadata, 'orderLineItemId')) {
continue;
}
$id = $metadata->orderLineItemId;
Expand Down
2 changes: 1 addition & 1 deletion src/ScheduledTask/OrderStatus/ExpireOrderTaskHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public function __construct(ScheduledTaskRepositoryInterface $scheduledTaskRepos

public function run(): void
{
$this->logger->info('Start resetting in_progress orders');
$this->logger->debug('Start resetting in_progress orders');

$context = new Context(new SystemSource());

Expand Down
Loading