NTR - optimizes custom domain overwrite #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @michnhokn thanks for the PR, could also fix the Unit tests for this? then i would merge it. best regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would suggest adapting the
applyCustomDomainmethod to replace not just the host but the full base URL. This way you can also control the schema as well as any ports.In the current implementation you might run into the problem that you have a local port like
8000which is not the case for the URL you want to replace it with. Then only the host is replaced, and Mollie will still try to access the new host on port8000, which is not what you want.This changes the behaviour of the
MOLLIE_SHOP_DOMAINenv variable a bit, because it should provide a schema. But it's not necessary.