Fix/piwoo 125 - Add woocommerce checkout blocks support #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inpsyde-maticluznar
changed the title
mmaymo
approved these changes
Aug 3, 2023
|
@mmaymo I had to restore some parts of the code that handled rendering of the payment methods on the checkout. Before that, Payment methods were registered using PaymentMethodRegistry in PHP, but this caused a lot of issues when we were trying to filter them. Now we generate payment method data using PHP and send it to JS where we do a registration. Because of that, payment method filtering now works. |
mmaymo
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Woocommerce checkout blocks require implementation of the following class:
Automattic\WooCommerce\Blocks\Payments\Integration\AbstractPaymentMethodTypeI implemented a class
MollieCheckoutBlocksSupport.phpwhich extendsAbstractPaymentMethodTypeand registered its object usingPaymentMethodRegistryinwoocommerce_blocks_payment_method_type_registrationhook.Some of the code was removed from the AssetModule and some of the code was moved from the AssetsModule to the MollieCheckoutBlocksSupport.
Additionally I updated Woocommerce stubs and included
<file name="vendor/php-stubs/woocommerce-stubs/woocommerce-packages-stubs.php"/>in psalm.xml.