Add missmatch to request lines #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return $line['totalAmount']['value']; | ||
| }, $this->order_lines)); | ||
| $orderTotalDiff = $orderTotalRounded - $linesTotal; | ||
| if (abs($orderTotalDiff) > 0) { |
There was a problem hiding this comment.
@mmaymo it looks good to me, but I have one question. There is one scenario that could cause problems. Maybe you know what happens. For example:
$orderTotalRounded - $linesTotal = 0.001
$this->order_lines[] = $missmatch;
Mollie may round this to 0.00 and we have a surcharge with 0.00. Can that happen?
There was a problem hiding this comment.
Good point, I'll check it
There was a problem hiding this comment.
Yeah, seems if the rounding makes the diff line send a 0 value there is no problem. The transaction went through without error.
There was a problem hiding this comment.
Great, thank you :)
inpsyde-maticluznar
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles PIWOO-501