Feature/style express piwoo 560 #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added css for the button added in cart and checkout block
# Conflicts: # inc/settings/mollie_applepay_settings.php
Removed the css styles. Hardcoded defaults. New component for the editor. Use the new component in cart and checkout.
inpsyde-maticluznar
requested changes
Nov 6, 2024
| @@ -11,6 +11,11 @@ export const ApplePayButtonComponent = ({cart, extensions}) => { | |||
| shop: {countryCode, currencyCode = 'EUR', totalLabel = ''}, | |||
| ajaxUrl, | |||
| } = mollieApplePayBlockDataCart | |||
| const { useMemo } = wp.element; | |||
There was a problem hiding this comment.
Try to import from @wordpress/element rather than from the global variable.
| @@ -0,0 +1,17 @@ | |||
| export const ApplePayButtonEditorComponent = ({ buttonAttributes = {} }) => { | |||
| const { useMemo } = wp.element; | |||
There was a problem hiding this comment.
Try to import from @wordpress/element rather than from the global variable.
| @@ -11,6 +11,11 @@ export const ApplePayButtonComponent = ({cart, extensions}) => { | |||
| shop: {countryCode, currencyCode = 'EUR', totalLabel = ''}, | |||
| ajaxUrl, | |||
| } = mollieApplePayBlockDataCart | |||
| const { useMemo } = wp.element; | |||
| const style = useMemo(() => ({ | |||
There was a problem hiding this comment.
I am not a React expert, but I think useMemo should be used for very expensive actions. If you decide to remove it, you can ignore my comments about importing useMemo from @wordpress/element
| @@ -0,0 +1,17 @@ | |||
| export const ApplePayButtonEditorComponent = ({ buttonAttributes = {} }) => { | |||
| const { useMemo } = wp.element; | |||
| const style = useMemo(() => ({ | |||
There was a problem hiding this comment.
The same applies here. I don't think useMemo is needed.
inpsyde-maticluznar
approved these changes
Nov 7, 2024
|
Fix phpcs before merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based in release 7.9.0-beta
Handles PIWOO-560