Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add manifest support #10

Merged
merged 6 commits into from
Feb 21, 2024
Merged

feat: add manifest support #10

merged 6 commits into from
Feb 21, 2024

Conversation

tmlye
Copy link
Member

@tmlye tmlye commented Feb 20, 2024

  • Add manifest support and make it the path to the manifest the default argument
  • Remove --image, --port and --env args as they are in the manifest
  • Refactor to make greater use of match and move new service creation to a separate method
  • Fix a bug where not having a default org in the config file caused a panic. Centralized getting org name code

Example manifest:

environment: hi
service:
  name: bla3
  image: nginx
  container_port: 80

@tmlye tmlye requested a review from bittermandel February 20, 2024 19:09
@bittermandel
Copy link
Contributor

Shouldn't the manifest be the default method?

@tmlye
Copy link
Member Author

tmlye commented Feb 21, 2024

Shouldn't the manifest be the default method?

Agree, updated

@tmlye
Copy link
Member Author

tmlye commented Feb 21, 2024

@bittermandel re-review please

@tmlye tmlye merged commit ef83f1a into main Feb 21, 2024
2 checks passed
@tmlye tmlye deleted the manifest-support branch February 21, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants